Fix unlisted-share preview flicker#1020
Draft
aasandei-vsp wants to merge 1 commit into
Draft
Conversation
Resolve isUnlistedShare and ephemeralFolder before SharePreviewComponent renders so the first paint matches the share's actual type, instead of defaulting to the restricted-share UI and swapping after an async API call. - Add primeForToken / isUnlistedShareSync to ShareLinksService and invalidate the cache on token change and on navigation off /share/ - Have ShareUrlResolveService prime the share-links cache in parallel with checkShareLink via Promise.all - Add ShareUrlEphemeralFolderResolveService so ephemeralFolder is on route data before the component constructs - Read isUnlistedShare synchronously in SharePreviewComponent and FileListItemComponent so blurred / real thumbnails are correct on first paint Issue: PER-10352
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
==========================================
+ Coverage 49.88% 50.00% +0.12%
==========================================
Files 348 349 +1
Lines 11501 11533 +32
Branches 1974 1981 +7
==========================================
+ Hits 5737 5767 +30
+ Misses 5576 5573 -3
- Partials 188 193 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve isUnlistedShare and ephemeralFolder before SharePreviewComponent renders so the first paint matches the share's actual type, instead of defaulting to the restricted-share UI and swapping after an async API call.
Issue: PER-10352