[PER-10415] [BLOCKED] New date editing full screen#1009
Open
aasandei-vsp wants to merge 11 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
==========================================
+ Coverage 49.88% 51.39% +1.50%
==========================================
Files 348 354 +6
Lines 11501 12035 +534
Branches 1974 2155 +181
==========================================
+ Hits 5737 6185 +448
- Misses 5576 5625 +49
- Partials 188 225 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…splay dates Add new getStelaFolderVOs method to retrieve updated folder information from the v2 API endpoint. This method handles both single and multiple folder requests with optional share token support. Add updateStelaFolder method to update folder date ranges by combining start and end dates into EDTF interval format before sending to the server. These changes enable proper synchronization of folder date information between the client and server when users edit date ranges in the UI. ISSUE: PER-10475
Add displayTime and displayEndTime getters to parse EDTF interval strings from the server. These getters split interval values like "1985-05-20/1990-06-15" into separate start and end dates for display in the UI. Update template to use the new getters instead of directly accessing displayDT and displayEndDT properties. Add fallback logic to use legacy properties when the displayTime interval is not available. ISSUE: PER-10475
This new component will be presentational, it will get a date input and it will also return a selected date. It includes a calendar. Issue: PER-10416
The time picker is a presentational component, its input si a time object and it returns a time object as well. It contains a time selector. It works with meridian. Issue: PER-10416
The edit date and time component is smart, because it manages its own state, but also the states of the time and date pickers. But still the state is isolated to this specific component, it gets as input a date and time object and returns back a date and time object. It handles the time picker, the date picker, the date qualifiers, start and end time and also shows an edtf calculated value. Issue: PER-10416
The service has the resposability to open the modal for the edit date time component and provide the initial data. Issue: PER-10416
Because we are using the timezone dropdown component in three places now, extracting it into a presentational component for reusability seems the right approach. It will be a generic isolated component that will provide an input and a dropdown for choosing the timezone. Issue: PER-10416
This component will be the smaller version to set the date and time, it will open the modal editor for more comporehensive choices. Issue: PER-10416
Issue: PER-10416
Moved all logic related to date and time types and validations, including EDTF mappings into a single point of truth, in the edtf service. This way the components will only be presentational and only manipulate their own internal state. ISSUE: PER-10416
Issue: PER-10415
aasandei-vsp
force-pushed
the
PER-10415-new-date-editing-full-screen
branch
from
f2608ad to
c37d8a3
Compare
aasandei-vsp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by: #924