fix: register routeplanner sub-routes correctly - #225
Merged
Conversation
routeplanner.ts has no dot in the filename, so it was getting registered as a single static route at /v4/routeplanner instead of the actual paths the handler dispatches on. every request to the route planner api was 404ing before the handler even ran, regardless of your routePlanner config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
added optional
pathsfield to ApiRouteModule so a module can register explicit static routes instead of relying on the filenameWhy
routeplanner.ts has no dot in the filename, so it registered as a single static route at /v4/routeplanner instead of the actual paths the handler dispatches on. every call 404s before the handler runs
Checkmarks
Additional information
tsc passes