Add regional calibration diagnostics (land cover and ecoregion breakdown) - #4069
Merged
Conversation
Breaks the ensemble calibration assessment down by region rather than a single domain-wide number, grouping the diagnostics by land cover class and by EPA/CEC ecoregion. Reuses the ensemble calibration diagnostics, so per-region numbers match the domain-wide ones. The grouping engine accepts any labels and any benchmark. Includes a notebook, tests, and figures (choropleth maps of calibration by ecoregion and bar charts by land cover and ecoregion). Land cover class labels are inferred from geography and the biomass and LAI signature and are marked for confirmation.
Replace the inferred land-cover class names with the MODIS MCD12Q1 PFT labels used in the North American reanalysis, confirmed against site geography. Regenerate the land-cover figures with the corrected labels and drop the narrative notebook.
mdietze
requested changes
Aug 24, 2026
Member
There was a problem hiding this comment.
this and the other png are Results, not code, and thus shouldn't be in the PR.
mdietze
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a regional breakdown of the ensemble calibration assessment. Rather than a single domain-wide number, it reports the calibration of the ensemble spread per region, grouped two ways, by land cover class and by EPA/CEC ecoregion. It builds on the ensemble calibration diagnostics in the calibration module, computing the same spread-to-error ratio and coverage on subsets of sites.
Contents (in modules/benchmark/inst/ilamb/calibration/):
The land cover class labels are the MODIS MCD12Q1 PFT classification used in the North American carbon reanalysis, with the class integers following the standard MODIS PFT coding, confirmed against site geography. The ecoregion breakdown uses the free CEC North American ecoregion shapefiles (Level 1 and Level 2), available from the EPA Ecoregions of North America page (https://www.epa.gov/eco-research/ecoregions-north-america) under its Downloads section.
Motivation and Context
Follow-on to the ensemble calibration work. A single domain-wide calibration number hides spatial structure. This reports calibration per land cover class and per ecoregion, showing where the ensemble spread is trustworthy and where it is not. The engine accepts any grouping and any benchmark, so future benchmarks and groupings plug into the same breakdown.
Review Time Estimate
Types of changes
Checklist: