[ISSUE-9735] KF of Desctruction Calc Error#9752
Open
FenikSRT4 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
[ISSUE-9735] KF of Desctruction Calc Error#9752FenikSRT4 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
FenikSRT4 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
* Regenerates the skills because of a reference to KineticFusilladeOfDestruction instead of to KineticFusilladeAltX which is the proper key for the skill. This reference was causing errors for some of the hover tooltips in the calcs tab.
FenikSRT4
commented
Apr 13, 2026
| -- This equals: X * (0 + 1 + 2 + ... + (n-1)) / n = X * n(n-1)/2 / n = X * (n-1)/2 | ||
| local avgMoreMult = moreDamagePerProj * (output.ProjectileCount - 1) / 2 | ||
| activeSkill.skillModList:NewMod("Damage", "MORE", avgMoreMult, "Skill:KineticFusilladeofDetonation", ModFlag.Hit) | ||
| activeSkill.skillModList:NewMod("Damage", "MORE", avgMoreMult, "Skill:KineticFusilladeAltX", ModFlag.Hit) |
Author
There was a problem hiding this comment.
This is the change that actually fixes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9735
Description of the problem being solved:
Regenerates the skills because of a reference to KineticFusilladeOfDestruction instead of to KineticFusilladeAltX which is the proper key for the skill. This reference was causing errors for some of the hover tooltips in the calcs tab.
I'm unsure if I should have allowed all of the generated changes, or just the one I'm targeting, but I figure because they are generated this would be expected. I am using the latest build of PoE as of the time of creating this PR.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
See issue.
After screenshot: