Add more specific jewel tooltip comparison sorting by sorting by:#9744
Open
vaisest wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Add more specific jewel tooltip comparison sorting by sorting by:#9744vaisest wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
vaisest wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
1. empty sockets 2. same base group jewel or same unique 3. DPS 4. EHP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This changes the sorting for jewel tooltips and helps with comparisons that are absurdly large, and occasionally unusable. It doesn't directly fix the problem as tooltips can still go off-screen, but showing more relevant sockets first means the tooltip is much more useful.
Sockets are sorted by:
The stat diff hiding tip is also moved to the top of the list so it's actually visible. Limit: x uniques also now only show comparisons with the slots that have the same unique, if the limit has been reached.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/FMc4FF8VymuS (adorned build from Poe.ninja)
Before screenshot:
After screenshot:
Comments welcome. This mostly seemed necessary because #9649 compares Watcher's eye's to all sockets and the tooltip doesn't have a scroll functionality. I'm not sure if this is better for other use cases.