Guard Trader result dropdown tooltip against stale state#9742
Open
mcagnion wants to merge 3 commits intoPathOfBuildingCommunity:devfrom
Open
Guard Trader result dropdown tooltip against stale state#9742mcagnion wants to merge 3 commits intoPathOfBuildingCommunity:devfrom
mcagnion wants to merge 3 commits intoPathOfBuildingCommunity:devfrom
Conversation
The nil guard lost during the vaisest/trader-improvements merge caused a crash when hovering the result dropdown after clearing search results. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mcagnion
force-pushed
the
bugfix/trade-query-tooltip-nil
branch
3 times, most recently
from
f853db1 to
8344d05
Compare
mcagnion
force-pushed
the
bugfix/trade-query-tooltip-nil
branch
from
8344d05 to
48859b1
Compare
Contributor
|
Hi, please remember to use TAB indentation. ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The Trader result dropdown tooltip can be evaluated after the sorted row state or backing result entry has changed, which can leave the callback pointing at missing entries and trigger nil accesses.
Description of the solution:
Add early-return guards in the
resultDropdowntooltip callback when:This keeps the nominal path unchanged and only hardens the callback against transient state desynchronization.
Steps taken to verify a working solution:
TestTradeQuery_spec.luacovering:sortedResultTbl[row_idx]rowNotes: