Open
Conversation
- move find button to separate slot instead of using exisitng jewel sockets - use exisitng Watcher's Eye slot(if available) for usage in weight calculations with test item - added option to include rest of applicable mods from Watcher's Eye mod pool that have weight 0 in final query
…against an equipped eye
vaisest
force-pushed
the
trader-improvements
branch
2 times, most recently
from
82899d0 to
1149f4f
Compare
vaisest
force-pushed
the
trader-improvements
branch
from
1149f4f to
688515e
Compare
…int vs enchant for amulets and belts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This solves some annoying steps with the trader tool. Notably it allows for and defaults to filtering out whisper listings, as these are often not actually going to be sold at the listed price. For async trade it also adds a button to show the result page as apparently GGG considers using the direct whisper/travel API to be past the line of breaking TOS.
Steps taken to verify a working solution:
Sample build
https://pobb.in/B2SI3YzPgw93 (just my avatar of fire BV)
Before screenshot:
Body Armour:
After screenshot:
Body Armour:
Amulet:
I have also implemented a copy setting that uses the currently equipped eldritch mods, enchants, and anoints. I think it makes sense to do this because it's quite rare for the results to have what you want, and they can be borderline required (as in the sample build gloves, which need fire conversion). It also helps show the true value of e.g. cord belts well.
Included are also fixes for #9678 which resulted in crashes and currency rates (and hence sorting) not working.
Note that this is based on the watcher's eye branch but I may have configured that incorrectly on Github.