Skip to content

Add support for adding vestigial implicits - #10156

Open
vaisest wants to merge 4 commits into
PathOfBuildingCommunity:devfrom
vaisest:add-vestigial
Open

Add support for adding vestigial implicits#10156
vaisest wants to merge 4 commits into
PathOfBuildingCommunity:devfrom
vaisest:add-vestigial

Conversation

@vaisest

@vaisest vaisest commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

This adds vestigial implicits to the add implicit menu. This was done by sort of exporting a list of mod id -> unique title it originates from. This allows us to know what modifiers are on which base types, and also allows us to show the source item.

The mods are sort of similar to the PoE2 handwraps in that they just have a prefix in the mod id, but there are a lot of things that aren't 1:1, and the biggest issue is that we don't have a perfect list of unique explicit mod ids. However, most of the were correct, and I manually corrected about 60 of them. I think most of them are correct now, and it should be better than poedb's list now. Still, this kind of sucks and needs a better solution in the future

Steps taken to verify a working solution:

  • Seems to work
  • Admittedly not well tested
  • Should be feature-complete

Link to a build that showcases this PR:

Before screenshot:

After screenshot:

Path{space}of{space}Building_2026-08-06_22-50-01 image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant