Fix Buy Similar searches for punctuated unique names - #10139
Merged
LocalIdentity merged 2 commits intoAug 6, 2026
Merged
Conversation
Keep official unique names intact while stripping user-added trailing numeric IDs.
mcagnion
force-pushed
the
bugfix/buy-similar-apostrophe-name
branch
from
August 5, 2026 22:03
8718bb9 to
5738bfe
Compare
mcagnion
marked this pull request as ready for review
August 5, 2026 22:06
LocalIdentity
approved these changes
Aug 6, 2026
LocalIdentity
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Buy Similar could generate an invalid Trade search for unique names containing punctuation, such as apostrophes. The unique name is now kept intact while an optional trailing numeric seed is still removed.
Steps taken to verify a working solution: