Skip to content

Fix crash when double clicking and dragging an item on small window sizes #10134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Aug 6, 2026
+5 −1
Merged

Fix crash when double clicking and dragging an item on small window sizes #10134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Classes/ItemDBControl.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ function ItemDBClass:Draw(viewPort)
end

function ItemDBClass:GetRowValue(column, index, item)
if column == 1 then
if item and column == 1 then
return colorCodes[item.rarity] .. item.name
end
end
Expand Down Expand Up @@ -359,6 +359,10 @@ function ItemDBClass:OnSelClick(index, item, doubleClick)
self.itemsTab:AddUndoState()
self.itemsTab.build.buildFlag = true
elseif doubleClick then
-- disallow dragging after double click since the window can jump when
-- the display item tooltip is created, which might cause the drag item
-- to get stuck to the cursor
self.selDragging = false
self.itemsTab:CreateDisplayItemFromRaw(item.raw, true)
return false
end
Expand Down
Loading