Skip to content

Fix crash caused by offhand granted skills #10128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cupkax wants to merge 1 commit into from
+1 −1
Closed

Fix crash caused by offhand granted skills #10128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Modules/CalcActiveSkill.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ function calcs.buildActiveSkillModList(env, activeSkill)
activeSkill.weapon2Flags = 0
else
-- Set weapon flags
if skillFlags.attack and activeSkill.socketGroup and activeSkill.socketGroup.sourceItem then
if skillFlags.attack and activeSkill.socketGroup and activeSkill.socketGroup.sourceItem and activeSkill.socketGroup.sourceItem.base and activeSkill.socketGroup.sourceItem.base.weapon then
-- Item-granted attacks use the weapon that grants the skill
local sourceSlot = activeSkill.socketGroup.slot or ""
skillFlags.forceMainHand = sourceSlot:match("^Weapon 1") ~= nil
Expand Down
Loading