Add sorting for modifier dropdowns in crafting UI - #10120
Merged
Conversation
The sorted list wasn't removing the current mod from the item before sorting the list so it could be skewed by the current selection Also disables the sort from running if the selection is hidden. The sort was running in the background for the cluster jewels even though it was hidden
The dropdown cut off the longer named stats
LocalIdentity
approved these changes
Aug 5, 2026
LocalIdentity
left a comment
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I fixed an issue with it not removing the currently selected mod from the item before sorting and also made the dropdown wider as it was cutting off stats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10023
Description of the problem being solved:
This adds a dropdown selector to the rare item crafting UI which controls sorting for the rare dropdowns. This allows for adding the modifier which grants the most power easily.
This also slightly refactors the dropdown code, which means that cluster jewels now have their modifiers combined. I couldn't see any reason for why they weren't included in the code and they seem to work fine.
I also moved the quality label by 4 px. It looked weird when everything else was in a straight line.
Steps taken to verify a working solution:
This is not super well tested, but is feature complete.
Link to a build that showcases this PR:
Before screenshot:
After screenshot: