Conversation
Wraps POST /v2/price_feed/price_feed and POST /v2/price_feed/price_feed_smoothed as client.price_feed_v2.price_feed and client.price_feed_v2.price_feed_smoothed, reusing PropertyTypeService so property_type (ALL, SINGLE_FAMILY, NEW_CONSTRUCTION) is sent in the POST body. ParclLabsService.url is now optional for POST-only endpoints. Bumps version to 1.19.0.
- POST requests send limit/offset as query params only; offset passed via params was previously misrouted into the JSON body and limit duplicated there - auto-pagination no longer re-applies the caller's initial offset on next pages - restore ServiceGroup.add_service positional order (url stays nullable and is passed explicitly as None for the POST-only v2 services) - PropertyTypeService / PortfolioSizeService copy the caller's params instead of mutating them - tests: positional registration, offset routing, param immutability, two-page pagination through requests.request, first-page-only default; live forced pagination (limit=2) and all three property_type values on both v2 routes - docs: page-size / auto_paginate behavior and API-side property_type validation
zhibindai26
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.