Add open_raw_zarr helper#2668
Open
VeckoTheGecko wants to merge 24 commits into
Open
Conversation
Split out data manipulation and grid creation from the construction of fields
Move all data validation code to the model itself
for more information, see https://pre-commit.ci
Ultimately we want to make the grid just dependent on the SGRID compliant model data since it contains all the information needed regarding staggering (we dont need xgcm anymore). I want to update the constructor to remove the xgcm grid object - so adding an adapter at the moment to help with refactoring (will be removed at a later date)
Also update calling code in model and field.py
For when adding fieldsets together
And add test
107d409 to
1f6ee4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This helper ingests a Zarr dataset into an Xarray dataset by bypassing Dask.
xref pydata/xarray#11236 (reply in thread)
PR is (somewhat) blocked by #2646 - at least #2646 greatly simplifies the number of Xarray objects we have flying around.
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure