Fixing OutOfBounds errors on field.eval#2665
Open
erikvansebille wants to merge 2 commits into
Open
Conversation
In the previous implementation, the GRID_SEARCH_ERROR, LEFT_OUT_OF_BOUNDS and RIGHT_OUT_OF_BOUNDS were negative values, but this could create confusion when a user would then use particles.ei (as negative values are wrapped in the array). See also Parcels-code#2629
fluidnumericsJoe
approved these changes
Jun 16, 2026
fluidnumericsJoe
left a comment
fluidnumericsJoe
left a comment
Contributor
There was a problem hiding this comment.
Nice! simple and elegant. Also avoids additional filtering stage in the interpolators or in field.eval to drop out particles not found in the mesh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the previous implementation, the
GRID_SEARCH_ERROR,LEFT_OUT_OF_BOUNDSandRIGHT_OUT_OF_BOUNDSwere negative values, but this could create confusion when a user would call afield.eval()directly. Instead, these constants are now set to very large valuesChecklist
Field.evalsilently returns wrong values for out-of-domain queries #2629mainfor normal development,v3-supportfor v3 support)AI Disclosure