Always load totalEntityAge#13918
Open
Rothes wants to merge 2 commits into
Open
Conversation
Contributor
|
It seems to have been done kinda on purpose in #12077 (comment) to not break the API, now this is indeed weird for the config value. |
Contributor
Author
|
If statement is now removed. I think we could keep the old API behavior. However, I think a better approach, is to add new API, so dev can get both ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This variable
totalEntityAgeseems always being saved, but only loads if entity is LivingEntity.I believe there was a reason not to load it when it was
tickCount, but since we have separated that, I don't see a reason why we don't load it anytime.despawnTimecould behave better on some projectiles (like wither skull) after this.