Add methods for CreakingHeart#12095
Conversation
notTamion
left a comment
There was a problem hiding this comment.
some grammar in the jd needs to be fixed
Lulu13022002
left a comment
There was a problem hiding this comment.
You should also handle unplaced block state properly
|
There is a lot of stuff depending on the despawn distance being 34. e.g. Creaking roaming distance and follow distance, redstone output, player spawning range. When setting the despawn distance to anything lower it will cause semi weird behaivour as the creaking will willingly move outside its despawn distance and etc. So i think we should either scale that stuff, Math.min it or add extra api for it. though leaving it half broken like this feels bad |
ok for that then im wait for some more feedback about what do...
|
- allow manage creaking attached - helper method for spawn creaking
…th for low values
Co-authored-by: Tamion <70228790+notTamion@users.noreply.github.com>
This reverts commit 0306df1.
9d00d07 to
179a9a0
Compare
|
A little bump of this... maybe can take the second option for add tags to the rest and make user handle all if wanna touch that (or remove the set and forget the problem) the only issue i has is where are the static fields being used.... many "32" and not sure what of all are for what :/ |
|
I remove the whole distance API based in the implications for support that, also update for the last changes in that block from NMS |
- Missing Nullable annotation for construct a instance with not location (like happen in clone) - Change how check the ServerLevel for avoid IDE warnings correctly
Owen1212055
left a comment
There was a problem hiding this comment.
The only thing I am unsure of is manually playing the sounds, I would think its fine without. Other than that, lgtm
You prefer user call sounds if wanna then? |
Warriorrrr
left a comment
There was a problem hiding this comment.
Re-approving to trigger workflow again
kennytv
left a comment
There was a problem hiding this comment.
It's so good that I need to approve again
Add more methods to the Creaking Heart