Skip to content

Add methods for CreakingHeart#12095

Open
Doc94 wants to merge 33 commits into
PaperMC:mainfrom
Doc94:feature/creaking-heart-methods
Open

Add methods for CreakingHeart#12095
Doc94 wants to merge 33 commits into
PaperMC:mainfrom
Doc94:feature/creaking-heart-methods

Conversation

@Doc94

@Doc94 Doc94 commented Feb 10, 2025

Copy link
Copy Markdown
Member

Add more methods to the Creaking Heart

@Doc94 Doc94 marked this pull request as ready for review February 10, 2025 13:05
@Doc94 Doc94 requested a review from a team as a code owner February 10, 2025 13:05

@notTamion notTamion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some grammar in the jd needs to be fixed

Comment thread paper-api/src/main/java/org/bukkit/block/CreakingHeart.java Outdated
Comment thread paper-api/src/main/java/org/bukkit/block/CreakingHeart.java Outdated

@Lulu13022002 Lulu13022002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also handle unplaced block state properly

Comment thread paper-api/src/main/java/org/bukkit/block/CreakingHeart.java Outdated
Comment thread paper-api/src/main/java/org/bukkit/block/CreakingHeart.java Outdated
Comment thread paper-api/src/main/java/org/bukkit/block/CreakingHeart.java Outdated
Comment thread paper-api/src/main/java/org/bukkit/block/CreakingHeart.java Outdated
@Doc94 Doc94 requested review from lynxplay and notTamion April 21, 2025 18:41
Comment thread paper-server/src/main/java/org/bukkit/craftbukkit/block/CraftCreakingHeart.java Outdated
Comment thread paper-server/src/main/java/org/bukkit/craftbukkit/block/CraftCreakingHeart.java Outdated
@notTamion

Copy link
Copy Markdown
Contributor

There is a lot of stuff depending on the despawn distance being 34. e.g. Creaking roaming distance and follow distance, redstone output, player spawning range. When setting the despawn distance to anything lower it will cause semi weird behaivour as the creaking will willingly move outside its despawn distance and etc. So i think we should either scale that stuff, Math.min it or add extra api for it. though leaving it half broken like this feels bad

@Doc94

Doc94 commented May 3, 2025

Copy link
Copy Markdown
Member Author

There is a lot of stuff depending on the despawn distance being 34. e.g. Creaking roaming distance and follow distance, redstone output, player spawning range. When setting the despawn distance to anything lower it will cause semi weird behaivour as the creaking will willingly move outside its despawn distance and etc. So i think we should either scale that stuff, Math.min it or add extra api for it. though leaving it half broken like this feels bad

ok for that then im wait for some more feedback about what do...

  • Add a min like Math.min(Math.abs(DISTANCE_CREAKING_TOO_FAR - 2), PLAYER_DETECTION_RANGE) where DISTANCE_CREAKING_TOO_FAR its the custom field
  • Add tags for the others limits and make the user handle that if its going to modify any for not restrict that behaviours

@lynxplay lynxplay moved this from PR Party candidate to Changes required in Paper PR Queue Aug 23, 2025
@Doc94 Doc94 force-pushed the feature/creaking-heart-methods branch from 9d00d07 to 179a9a0 Compare November 22, 2025 12:37
@Doc94

Doc94 commented Nov 22, 2025

Copy link
Copy Markdown
Member Author

A little bump of this... maybe can take the second option for add tags to the rest and make user handle all if wanna touch that (or remove the set and forget the problem) the only issue i has is where are the static fields being used.... many "32" and not sure what of all are for what :/

@Doc94

Doc94 commented Feb 9, 2026

Copy link
Copy Markdown
Member Author

I remove the whole distance API based in the implications for support that, also update for the last changes in that block from NMS

Doc94 and others added 3 commits February 28, 2026 09:34
- Missing Nullable annotation for construct a instance with not location (like happen in clone)
- Change how check the ServerLevel for avoid IDE warnings correctly

@Owen1212055 Owen1212055 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I am unsure of is manually playing the sounds, I would think its fine without. Other than that, lgtm

@Doc94

Doc94 commented May 3, 2026

Copy link
Copy Markdown
Member Author

The only thing I am unsure of is manually playing the sounds, I would think its fine without. Other than that, lgtm

You prefer user call sounds if wanna then?

@Warriorrrr Warriorrrr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving to trigger workflow again

@Warriorrrr Warriorrrr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this

@kennytv kennytv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so good that I need to approve again

@papermc-projects papermc-projects Bot moved this from Changes required to Full approval in Paper PR Queue Jul 15, 2026
@Warriorrrr Warriorrrr added the type: feature Request for a new Feature. label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: api type: feature Request for a new Feature.

Projects

Status: Full approval

Development

Successfully merging this pull request may close these issues.

7 participants