Skip to content

PackageKit::Offline::Results: Make castable to QDBusPendingCall #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arrowd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PackageKit::Offline::Results: Make castable to QDBusPendingCall #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/offline.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ class PACKAGEKITQT_LIBRARY Offline : public QObject
qulonglong timeFinished() const;
Transaction::Error error() const;
QString errorDescription() const;

operator QDBusPendingCall() const { return m_reply; }

@aleixpol aleixpol Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add a getter? Explicit is often clearer, I can see how it would seem magical in this case.

@arrowd arrowd Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My take is that PackageKit::Offline::Results is a QDBusPendingCall. It wraps this single value, so making it act as plain QDBusPendingCall makes sense to me.

private:
QDBusPendingReply<bool, QStringList, quint32, qulonglong, quint32, QString> m_reply;
};
Expand Down
Loading