refactor: Minor refactoring in resolver subsystem - #6125
Open
kgutwin wants to merge 2 commits into
Open
Conversation
prql-bot
approved these changes
Aug 3, 2026
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been reviewing the resolver code in hopes of proposing fixes for a few bugs or other inconsistencies. During my code review, I found a couple small tweaks that have no effect on the test suite or logic flow -- only code layout or other minor changes.
reporting.rsthat had previously been used for debug logging prior to the HTML logging systemBoxes withinfold_expr()fold_statements()into individualfold_xyz_stmt()functions so thatfold_statements()is easier to readI don't plan on including a changelog entry since none of these changes should have any user-visible effects.