Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ jobs:
name: Lint & Format
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
- uses: actions/checkout@v7
- uses: pnpm/action-setup@v6
with:
version: latest
- uses: actions/setup-node@v4
version: 10
- uses: actions/setup-node@v6
with:
node-version: 22
cache: pnpm
Expand All @@ -31,11 +31,11 @@ jobs:
name: Type Check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
- uses: actions/checkout@v7
- uses: pnpm/action-setup@v6
with:
version: latest
- uses: actions/setup-node@v4
version: 10
- uses: actions/setup-node@v6
with:
node-version: 22
cache: pnpm
Expand All @@ -47,18 +47,18 @@ jobs:
name: Test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
- uses: actions/checkout@v7
- uses: pnpm/action-setup@v6
with:
version: latest
- uses: actions/setup-node@v4
version: 10
- uses: actions/setup-node@v6
with:
node-version: 22
cache: pnpm
cache-dependency-path: app/pnpm-lock.yaml
- run: pnpm install --frozen-lockfile
- run: pnpm test
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v7
if: always()
with:
name: coverage-report
Expand All @@ -70,11 +70,11 @@ jobs:
runs-on: ubuntu-latest
needs: [lint, typecheck, test]
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
- uses: actions/checkout@v7
- uses: pnpm/action-setup@v6
with:
version: latest
- uses: actions/setup-node@v4
version: 10
- uses: actions/setup-node@v6
with:
node-version: 22
cache: pnpm
Expand Down
19 changes: 13 additions & 6 deletions app/pnpm-workspace.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
# pnpm build-script approval. pnpm v11 replaced onlyBuiltDependencies with
# `allowBuilds`; this allows esbuild's (and sharp's) postinstall so CI's
# `pnpm install --frozen-lockfile` passes instead of ERR_PNPM_IGNORED_BUILDS.
allowBuilds:
esbuild: true
sharp: true
# Approve the dependencies allowed to run install/build scripts during
# `pnpm install` (pnpm blocks dependency build scripts by default). This is
# pnpm v10's documented mechanism — https://pnpm.io/settings#onlybuiltdependencies
# — so CI's `pnpm install --frozen-lockfile` runs them and exits 0 instead of
# failing with ERR_PNPM_IGNORED_BUILDS.
#
# The pnpm major is pinned to 10 in .github/workflows/ci.yml because pnpm v11
# renames this key to `allowBuilds` (and ignores `onlyBuiltDependencies`); keep
# the two in sync. esbuild ships a native postinstall; sharp is listed
# defensively (it uses prebuilt @img/* binaries today, with no install script).
onlyBuiltDependencies:
- esbuild
- sharp
Loading