fix(laravel): index commands registered via withCommands() and their aliases

[krist7599555]

Caution

This is vibe code fix

How this was discovered

Found in a Laravel 13 project whose Artisan commands live in app/Actions/Sync/, registered via withCommands() in bootstrap/app.php and declared with the Laravel 11 #[Signature] attribute.

The LSP flagged $this->call('sync:forma-projects') as "Unknown command: 'sync:forma-projects'", while at the same time:

• php artisan list registered the command, and
• phpantom_lsp analyze (via composer analyze) reported zero findings.

So the CLI and the LSP disagreed about the same command set. Digging into the source showed why:

1. analyze also runs collect_fast_diagnostics, but the command-name check is gated on a non-empty index (if command_names.is_empty() { continue; }), and the headless analyze path never built the index — so the check was skipped entirely and "No errors" was not actually validation.
2. The LSP does build the index, but discovery only saw *Command-named classes and files under Console/Commands/, and name recovery didn't understand the #[Signature] attribute — so the command was genuinely missing from the index and the warning was a false positive.

The analyze-side index gap has since been addressed upstream (6dc9a7a); the discovery and attribute gaps remained and are what this PR fixes.

Summary

The Artisan command index only treated classes whose short name ends in Command or files under Console/Commands/ as candidates, and recovered command names only from $signature, $name, and #[AsCommand]. Laravel 11+ registers commands differently:

1. withCommands() in bootstrap/app.php loads commands from arbitrary directories (e.g. app/Actions/Sync) whose classes use the #[Signature('name {--opt}')] attribute — none of which the index recognizes.
2. Commands can answer to aliases via #[Aliases([...])], the aliases: argument of #[Signature]/#[AsCommand], or Symfony's #[AsCommand(aliases: ...)] — none of which are indexed.

Both gaps produce the same false positive: $this->call('sync:forma-projects') (or Artisan::call('<alias>')) is reported as "Unknown command" by the LSP even though php artisan list registers it.

Fix

1. Complete candidate discovery (server.rs — build_laravel_command_index + refresh_laravel_command_index)

Candidates are now: short name ends in Command or under Console/Commands/ or any non-vendor project class — scan_command_file's extends-Command/attribute checks decide. The byte pre-filter (signature/Signature/AsCommand/$name) keeps this cheap.

2. Recover the name from #[Signature] (commands.rs)

• new signature_attribute_value() helper — the Laravel 11+ attribute form of $signature — used in command_from_class (after #[AsCommand], before the $signature property) and command_signature_at_offset (so $this->option('...') validates for attribute-declared commands).

3. Index command aliases (commands.rs)

• CommandEntry gains aliases: Vec<String>; LaravelCommandIndex indexes each alias alongside the primary name (get()/all_names() resolve aliases).
• command_aliases() recovers aliases from #[Aliases([...])] (which wins, mirroring Illuminate\Console\Command::configureFromAttributes) and the aliases: argument of #[Signature]/#[AsCommand] (named or positional).

Tests

Five unit tests in commands_tests.rs:

• scans_signature_attribute_command_class / resolves_enclosing_signature_from_attribute — #[Signature] name + option recovery.
• indexes_standalone_aliases_attribute / indexes_signature_and_as_command_aliases / index_resolves_alias_names — alias recovery from all three attribute sources, plus index lookup via alias.

Verification

• Full lib suite: 4968 passed, 0 failed (was 4965 before this change).
• End-to-end on a Laravel app using withCommands([... app/Actions/Sync]):
  • real commands and real aliases → no warning;
  • $this->call('sync:does-not-exist') → correctly reported Unknown command;
  • composer analyze stays at zero findings, and now genuinely validates command names.

Notes for maintainers

• The analyze (CLI) path already builds the index (added in 6dc9a7a1), so this change makes both modes agree — no CLI-side change needed here.
• Attribute list checked against the current laravel/framework 13.x (v13.24.0): Aliases, Description, Help, Hidden, Signature, Usage — Description/Help/Hidden/Usage don't affect name resolution, so only the aliases family was addressed.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 84.61538% with 16 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/virtual_members/laravel/commands.rs	84.61%	16 Missing ⚠️

📢 Thoughts on this report? Let us know!