test(vstack): align with Paddle compat vstack behavior#65
Open
youge325 wants to merge 10 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new cross-framework compatibility test suite for at::vstack and updates the Chinese C++ API mapping document to mark at::vstack as fully compatible in the compat layer.
Changes:
- Added
test/ATen/ops/VStackTest.cppwith shape/dtype/exception coverage forat::vstack. - Updated
doc/cpp_api_mapping_cn.mdto moveat::vstackfrom “功能缺失” to “API 完全一致” and adjusted summary counts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/ATen/ops/VStackTest.cpp | Adds compatibility test cases that write vstack results (shape + some dtype/exception signals) to the shared result file for cross-framework comparison. |
| doc/cpp_api_mapping_cn.md | Updates mapping/status tables and statistics to reflect at::vstack being fully supported. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | 65 | `at::zeros` | `at::zeros` (compat层) | API 完全一致 | - | | ||
| | 65 | `at::vstack` | `at::vstack` (compat层) | API 完全一致 | - | | ||
| | 66 | `at::zeros` | `at::zeros` (compat层) | API 完全一致 | - | | ||
| | 66 | `at::zeros_like` | `at::zeros_like` (compat层) | API 完全一致 | - | |
Comment on lines
1215
to
1216
| | 789 | `at::xor` | - | 功能缺失 | - | | ||
| | 790 | `at::zero` | - | 功能缺失 | - | |
- Add VStackTest.cpp covering shape/dtype/exception cases: - Scalar (0D), small shape (1D/2D), large shape, zero-dim, all-ones, mixed dims - Dtype: kFloat, kDouble, kInt, kLong - Empty list exception handling - Update cpp_api_mapping_cn.md: at::vstack from 功能缺失 to API完全一致 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
youge325
force-pushed
the
test/vstack-20260528
branch
from
70c7b57 to
50b314d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add cross-framework compatibility test for
at::vstack.Changes
test/ATen/ops/VStackTest.cppwith 12 test cases covering shape/dtype/exceptiondoc/cpp_api_mapping_cn.md:at::vstackstatus changed from 功能缺失 to API完全一致Test Coverage
Related
Related: PaddlePaddle/Paddle#79175