You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wouldn’t it be better to merge the PR into a test branch instead of main while we run tests and confirm that the new dependency, or its integration, doesn’t introduce any new errors ?
Wouldn’t it be better to merge the PR into a test branch instead of main while we run tests and confirm that the new dependency, or its integration, doesn’t introduce any new errors ?
It's fairly safe. Easy to revert if anything goes wrong, and having it on main gives us an opportunity to test it more thoroughly. Most people serious about ImGui actually use freetype instead of truetype, so it's not like we're doing anything weird or likely to break here.
Wouldn’t it be better to merge the PR into a test branch instead of main while we run tests and confirm that the new dependency, or its integration, doesn’t introduce any new errors ?
It's fairly safe. Easy to revert if anything goes wrong, and having it on main gives us an opportunity to test it more thoroughly. Most people serious about ImGui actually use freetype instead of truetype, so it's not like we're doing anything weird or likely to break here.
Okay, I trust you then, I'm just suggesting it in case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EditorSomething relative with the editorGraphicsGraphical feature
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes #681
Review Guidance
Write here.
Screenshots/GIFs
Before (truetype + Ruda-Bold)
After (freetype + Roboto)
AI Usage Disclosure
None
Checklist