Reduced shader program state changes & property uploads#814
Merged
Conversation
f4de93d to
98d7266
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #811.
This PR aims to reduce shader program state changes & property uploads by:
GetVariantmethoddefaultValuetoMaterialPropertyinstead of calling the expensiveUniformToPropertyValueevery time a single use property need to be resetRelated Issue(s)
Fixes #445
Review Guidance
Write here.
Screenshots/GIFs
DrawFrame (Cargo)
Went from ~7.79ms to 3.78ms.
DrawEntity
Went from expensive draws...
to one initial draw, and cheap subsequent draws, thanks to property caching.
AI Usage Disclosure
None
Checklist