fix(cache): recover from corrupt scalar entries - #2828
Open
HandSonic wants to merge 1 commit into
Open
Conversation
HandSonic
force-pushed
the
fix/cache-corrupt-fallback
branch
from
September 3, 2026 18:20
cfd756e to
8618ac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue was found.
Summary
A malformed scalar JSON entry escaped
CacheManagebefore the configured fallback loader could run, so the same cache key remained unusable for its TTL. This change catches scalar deserialization failures, removes only the corrupt key, and lets the existing fallback path rebuild and cache a valid value.Affected surfaces
Verification
JSONException: input endbefore fallback.CacheManageTest: 6 tests passed.git diff --check origin/main...HEAD: passed.Risk and compatibility
Reviewer map
CacheManage.CacheStore.getand the corrupt scalar regression case.8618ac7e9edd87667ac9c0674f6b5516922956e3; no migration is required.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, automated tests, verification, and adversarial review.