Skip to content

Hydrex AMO deployment#2887

Open
sparrowDom wants to merge 3 commits intomasterfrom
sparrowDom/deploy_base_48
Open

Hydrex AMO deployment#2887
sparrowDom wants to merge 3 commits intomasterfrom
sparrowDom/deploy_base_48

Conversation

@sparrowDom
Copy link
Copy Markdown
Member

@sparrowDom sparrowDom commented May 6, 2026

Code change PR: #2886

Deployment

Contract Address
OETHbHydrexAMOProxy 0x926846b8fa246B30652B103C369fce5db8B2F593
OUSDCurveAMOStrategy 0x8DAAF5095bb64ad423cfC994b1C3E5291960fF0D

Sol2uml

sol2uml diff 0x926846b8fa246B30652B103C369fce5db8B2F593  .,node_modules --network base --apiKey [ETHERSCAN_API_KEY]

sol2uml diff 0x8DAAF5095bb64ad423cfC994b1C3E5291960fF0D  .,node_modules --network base --apiKey [ETHERSCAN_API_KEY]

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.83%. Comparing base (b26695a) to head (3057fb7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2887   +/-   ##
=======================================
  Coverage   41.83%   41.83%           
=======================================
  Files         114      114           
  Lines        4917     4917           
  Branches     1362     1362           
=======================================
  Hits         2057     2057           
  Misses       2857     2857           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sparrowDom sparrowDom changed the title Sparrow dom/deploy base 48 Hydrex AMO deployment May 6, 2026
Copy link
Copy Markdown
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared the "InitializeGovernedUpgradeabilityProxy" contract with address 0x926846b8fa246B30652B103C369fce5db8B2F593 on base
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/utils/Address.sol
match   contracts/governance/Governable.sol
match   contracts/proxies/InitializeGovernedUpgradeabilityProxy.sol
changed contracts/proxies/Proxies.sol

Copy link
Copy Markdown
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ sol2uml diff 0x8daaf5095bb64ad423cfc994b1c3e5291960ff0d  .,node_modules --network base --apiKey $ETHERSCAN_API_KEY
Compared the "OETHbHydrexAMOStrategy" contract with address 0x8DAAF5095bb64ad423cfC994b1C3E5291960fF0D on base
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol
match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   @openzeppelin/contracts/utils/math/SafeMath.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/algebra/IAlgebraGauge.sol
match   contracts/interfaces/algebra/IAlgebraPair.sol
match   contracts/interfaces/hydrex/IHydrexGauge.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/interfaces/IVault.sol
match   contracts/strategies/algebra/StableSwapAMMStrategy.sol
match   contracts/strategies/hydrex/OETHbHydrexAMOStrategy.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/utils/InitializableAbstractStrategy.sol
match   contracts/utils/PRBMath.sol
match   contracts/utils/StableMath.sol
match   contracts/vault/VaultStorage.sol

Copy link
Copy Markdown
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script. (Someone tried to takeover ownership blindly but those reverted as expected).
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants