Allow initial deposits to activate validators#2885
Open
naddison36 wants to merge 10 commits intomasterfrom
Open
Allow initial deposits to activate validators#2885naddison36 wants to merge 10 commits intomasterfrom
naddison36 wants to merge 10 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2885 +/- ##
==========================================
+ Coverage 41.59% 41.94% +0.35%
==========================================
Files 113 113
Lines 4916 4925 +9
Branches 1362 1365 +3
==========================================
+ Hits 2045 2066 +21
+ Misses 2868 2856 -12
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sparrowDom
reviewed
May 4, 2026
Member
sparrowDom
left a comment
There was a problem hiding this comment.
Looks good. There is one thing in the tests where comments don't align with code. Also I think it would be cool, that both compounding staking strategy contract setups are tested: when initial deposit is configured to 1 ETH / 32.24 ETH.
| it("Should stake to a validator: 1 ETH", async () => { | ||
| await stakeValidators(0, 1); | ||
| it("Should stake to a validator: 32.25 ETH", async () => { | ||
| await stakeValidators(0, INITIAL_DEPOSIT_AMOUNT); |
Member
There was a problem hiding this comment.
Multiple places in the test files comments state that 32.25 ETH has been deposited while using a constant INITIAL_DEPOSIT_AMOUNT which is set to 1 ETH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
While the Ethereum validator deposit queue is long (> 20 days), doing two deposits to get an active validator is too long. This change allows the governor to set the initial deposit to 32.25 ETH which will allow a validator to become active from just one deposit.
Once the deposit queue gets down to a more reasonable length, eg < 10 days, the initial deposit can be changed back to 1 ETH via a governance proposal.
Code Change Checklist
To be completed before internal review begins:
Internal review: