Skip to content

Signal forwarding for edge calls - #315

Open
mosherBT wants to merge 3 commits into
masterfrom
web-sdk-signals
Open

Signal forwarding for edge calls#315
mosherBT wants to merge 3 commits into
masterfrom
web-sdk-signals

Conversation

@mosherBT

@mosherBT mosherBT commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Why

Edge accepts an optional sig param carrying soft device/browser signals. Adding it to buildRequest here to allow passing it to edge.

What Changed

  • core/signals.ts: forwards lang, tz, scr, mem, cores, encoded as query-string pairs then base64url without padding.
  • core/network.ts: sets sig, gated on consent.deviceAccess.

How to Test

Tests added to cover changes.

TODO: Manual testing

  • Tested
  • Docs / README updated (if public API changed)

Notes

  • Breaking change
  • Requires release

@mosherBT mosherBT self-assigned this Aug 13, 2026
@mosherBT
mosherBT requested review from a team as code owners August 13, 2026 15:40
@mosherBT
mosherBT requested review from jimdennis-optable and juanli16 and removed request for jimdennis-optable August 13, 2026 15:40
@mosherBT mosherBT changed the title Signal collection for edge calls Signal forwarding for edge calls Aug 13, 2026

@zuolongwu-optable zuolongwu-optable left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants