fix(api): bump fastify 5.6→5.8 and @trpc/server 11.6→11.16#341
fix(api): bump fastify 5.6→5.8 and @trpc/server 11.6→11.16#341raonitimo wants to merge 1 commit intoOpenpanel-dev:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDependency version ranges were updated in three package manifests: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/trpc/package.json (1)
23-24: Align@trpc/clientand@trpc/serverto the same minor version.Line 24 bumps server to
^11.16.0while line 23 keeps client at^11.6.0. This misalignment is problematic for a type-safe framework like tRPC—both packages should share the same minor version for type and protocol consistency. Update@trpc/clientto^11.16.0to match the server version.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/trpc/package.json` around lines 23 - 24, Update the dependency version for `@trpc/client` so it matches `@trpc/server`: change the "@trpc/client" entry currently set to "^11.6.0" to "^11.16.0" so both "@trpc/client" and "@trpc/server" use the same minor version, ensuring type/protocol compatibility between the two packages.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/trpc/package.json`:
- Around line 23-24: Update the dependency version for `@trpc/client` so it
matches `@trpc/server`: change the "@trpc/client" entry currently set to "^11.6.0"
to "^11.16.0" so both "@trpc/client" and "@trpc/server" use the same minor
version, ensuring type/protocol compatibility between the two packages.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 19bbb2a5-625e-48fa-95ef-c298e7de9855
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
apps/api/package.jsonpackages/trpc/package.json
059f047 to
f5599cd
Compare
Addresses two HIGH-severity CVEs found via Trivy scan on a self-hosted deployment: - fastify 5.6.1 → 5.8.5: fixes CVE-2026-25223 (validation bypass via malformed Content-Type header). Attacker can bypass Fastify's request schema validation by crafting the Content-Type header, potentially sending malformed payloads to validated endpoints like /track. - @trpc/server 11.6.0 → 11.16.0: fixes CVE-2025-68130 (prototype pollution in experimental_nextAppDirCaller). Lower risk since openpanel may not use that API, but the bump is semver-compatible and brings other stability fixes. Also aligns @trpc/client to 11.16.0 across all packages (was 11.6.0 in packages/trpc and apps/start) so client and server stay on the same minor — mismatched versions can cause subtle serialization bugs. Both are ^-ranged deps — pnpm update resolves to latest compatible. Verified: `pnpm --filter @openpanel/api build` succeeds.
f5599cd to
b51bba1
Compare
Addresses two HIGH-severity CVEs found via Trivy scan on a self-hosted deployment:
fastify 5.6.1 → 5.8.5
CVE-2026-25223 — Validation bypass via malformed Content-Type header. An attacker can craft the
Content-Typeto bypass Fastify's request schema validation, sending malformed payloads to validated endpoints like/track. Directly exploitable on any internet-facing openpanel API.@trpc/server 11.6.0 → 11.16.0
CVE-2025-68130 — Prototype pollution in
experimental_nextAppDirCaller. Lower risk (openpanel may not use that specific API path), but the bump is semver-compatible and brings stability fixes.What changed
apps/api/package.json: bumpfastify+@trpc/serverpackages/trpc/package.json: bump@trpc/serverpnpm-lock.yaml: resolvedVerified
pnpm install— cleanpnpm --filter @openpanel/api build— succeedsSummary by CodeRabbit