Fix "translates custom oids to their long name" test#488
Open
anthonyryan1 wants to merge 1 commit into
Open
Conversation
Sharpie
approved these changes
Jul 14, 2026
Sharpie
left a comment
Sharpie
left a comment
Member
There was a problem hiding this comment.
Makes sense to me. Thanks for the fix!
Member
|
@anthonyryan1 you will need to sign the commit with a SSH or GPG key in order for this pull request to be mergable. |
Previously, this test used puppet from $PATH on Linux, and if you ran the test suite in a git repo, it would accidentally test the puppet version that was already installed on the system (rather than the one you are actively working on), and the test would fail if puppet was not installed. I fixed the test to use a relative puppet path, so that we aren't getting accidentaly pass/fail from the wrong binary. Signed-off-by: Anthony Ryan <anthonyryan1@gmail.com>
Contributor
Author
|
Added my SSH git signature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this test used puppet from $PATH on Linux, and if you ran the test suite in a git repo, it would accidentally test the puppet version that was already installed on the system (rather than the one you are actively working on), and the test would fail if puppet was not installed.
I fixed the test to use a relative puppet path, so that we aren't getting accidentaly pass/fail from the wrong binary.
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent