SESSION-2: handler mutation-propagation discipline#65
Draft
JarbasAl wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bba3e4a to
5f3aaee
Compare
5f3aaee to
c9b2726
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from the CONVERSE-1 feature PR (#25) per the 1 file, 1 PR rule — this is the only edit to
ovos-session-2.md.Change (ovos-session-2.md §2.4)
A handler that mutates session in-place but emits no Message has no bus-visible way to propagate those mutations. The handler-lifecycle trio
.complete(PIPELINE-1 §8) is orchestrator-emitted from the dispatch context and does not reflect handler-side in-place changes (especially out-of-process). Such a handler MUST emit at least one Message (ovos.utterance.speakorovos.session.syncper §2.7) for the state to appear in terminal events.Clarification of existing behaviour — backwards-compatible (V1), Version unchanged. Adds the missing SESSION-2 CHANGELOG section.
CONVERSE-1 (#25) drops this companion edit and forward-references this PR.