Skip to content

INTENT-4: session-scoped registration + required_slots#45

Merged
JarbasAl merged 1 commit into
devfrom
spec/intent4-session-scoped
Jun 26, 2026
Merged

INTENT-4: session-scoped registration + required_slots#45
JarbasAl merged 1 commit into
devfrom
spec/intent4-session-scoped

Conversation

@JarbasAl

@JarbasAl JarbasAl commented May 28, 2026

Copy link
Copy Markdown
Member

Companion issue: #47

Summary

Every intent registration is automatically keyed by session_id from context.session.session_id — no wire-shape change needed. "default" is the global/inherited scope; all sessions inherit it. Session-scoped registrations extend the pool; the existing blacklist fields are the sole narrowing mechanism.

Effective pool for session X: default intents ∪ session-X intents − blacklisted entries

Dispatch of session-scoped intents routes back through the bridge transparently via existing MSG-1 destination-based routing (BRIDGE-1 §3.2).

Changes

  • §1 scope — add session-scoped registration to defined list
  • §8.1 — replacement key is now quintuple (session_id, skill_id, intent_name, lang, method); session_id read from context.session.session_id, never from message.data
  • §8.4ovos.skill.deregister gains optional session_id field for bulk satellite cleanup on disconnect
  • §10.1ovos.intent.list gains optional session_id filter returning the effective pool (default ∪ session-specific); response entries include session_id
  • §11 (new) — full model: indexing, inheritance rule, deregistration/teardown, plugin visibility, dispatch routing
  • §12 conformance (renumbered from §11) — orchestrator MUST key manifest by quintuple; serve session-aware list queries

Companion

BRIDGE-1 §4.4 (PR #43) documents the satellite skill registration pattern this spec enables.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@JarbasAl, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 38 minutes and 5 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6281a751-4890-4ac3-815d-b12e32e9a353

📥 Commits

Reviewing files that changed from the base of the PR and between bcaa32b and b32554b.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • intent-4.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spec/intent4-session-scoped

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl

Copy link
Copy Markdown
Member Author

Merge-ready (MERGEABLE, dev merged in). Template conformance: header present, RFC-2119 boilerplate present, §11 session-scoped registration section well-formed with sub-sections 11.1–11.5. Added: CHANGELOG entry for the §11 addition (normative content was added without one). session_id sourced from context.session.session_id per §11.1 (correct per MSG-1/SESSION-1). Note: after #55 merges, GLOSSARY.md in this branch will need ovos-intent-*.md links updated.

@JarbasAl JarbasAl force-pushed the spec/intent4-session-scoped branch 2 times, most recently from ecba169 to 8fc2ac7 Compare June 22, 2026 17:16
@JarbasAl JarbasAl changed the title INTENT-4 §11: session-scoped intent registration INTENT-4: session-scoped registration + required_slots Jun 22, 2026
JarbasAl added a commit that referenced this pull request Jun 22, 2026
… class)

Narrowed from the multi-spec union-slots PR to ovos-intent-1.md only, per
the 1-file-1-PR rule. The INTENT-3 required_slots half moves to the INTENT-3
PR, the INTENT-4 payload field to the INTENT-4 PR (#45), and the orchestrator
backstop to the PIPELINE-1 PR.

- §5.5 — slot-consistency narrowed to .dialog only. A .intent file MAY now
  declare different slot sets across templates (union semantics); the engine
  extracts only the slots of the best-matching template. .dialog keeps the
  strict consistency rule.
- §6.2 — engine obligation updated: verify a consistent slot set for .dialog
  training data; accept differing slot sets for .intent.
- appendix/patterns.md §3.4 (non-normative) — authoring patterns for union
  slot sets and required_slots.

This relaxes a prior constraint, so every previously-valid file stays valid:
backwards-compatible. INTENT-1 is already V2 (the <name> inline-vocabulary
token); this addition does not change the class, so the Version stays 2.

Also drops the stray VERSIONING.md / ngi.png / README edits the original
branch carried, which were unrelated to this change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@JarbasAl JarbasAl force-pushed the spec/intent4-session-scoped branch 4 times, most recently from 43128cd to 607d602 Compare June 23, 2026 05:21
@JarbasAl JarbasAl force-pushed the spec/intent4-session-scoped branch from 607d602 to b32554b Compare June 26, 2026 17:57
@JarbasAl JarbasAl marked this pull request as ready for review June 26, 2026 20:55
@JarbasAl JarbasAl merged commit 232c423 into dev Jun 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant