Never break after operator#757
Open
wvpm wants to merge 5 commits into
Open
Conversation
…fiersum Minimise allocations for ModifierSum
Paralellise update gamestate & modifiers
wvpm
changed the title
wvpm
changed the title
wvpm
force-pushed
the
dev_never_break_after_operator
branch
from
8aea9d1 to
f65fcc9
Compare
Spartan322
changed the title
Spartan322
requested changes
May 23, 2026
Member
There was a problem hiding this comment.
Aside from the fact I will never permit merge commits inside an approved PR, I also won't approve anything in regards to "not breaking after operators", formatters will be required and I am not accepting any compromise on that but I also don't remotely agree with this claim regarding operators, in fact I find the styling here, aside from the lack of formatting, atrocious and would be absolutely horrified to see this continued any further in the codebase, I will never approve this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #672
Stacked on top of #756
Never break after operators.
Operators are the most important signal of what the code does.
They should always be in sight and never at the end of a line like an afterthought.