Misc Improvements#28
Merged
Merged
Conversation
That makes it easier to find the right logs after the run. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
In older Ubuntu versions resolvectl is part of the build dependencies of OpenVPN (in newer versions it is a separate package). But we do not have systemd running in the containers. So running resolvectl just gives a warning. Avoid that. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Due to us using TEST_RUN_GROUP the logs are very short. In case there are any failures it is very useful to have them. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
There was a problem hiding this comment.
Pull request overview
This PR makes small reliability/debuggability improvements to the OpenVPN test harness scripts by increasing the amount of diagnostic output captured/printed on failures and by improving log directory naming and DNS-info collection on Linux.
Changes:
- Print full client logs when a test run fails (including the “some tests failed” return code path).
- Include
TEST_RUN_GROUPint_client.shlog directory names to make multi-group runs easier to correlate. - Gate
resolvectl statuscollection on a systemd runtime marker to avoid running it on non-systemd Linux environments.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
t_server/original/run_t_clients.sh |
Expands failure diagnostics by printing the full per-run log (not just the tail) and adds extra output for rc=30 failures. |
t_server/original/client_vm/bin/t_client.sh |
Adds group suffix to log directory names and avoids calling resolvectl unless systemd is present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
uddr
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small improvements done during reliability testing.