Remove logging of full db url when the connection fails. - #4220
Open
MyPhonesAlex wants to merge 1 commit into
Open
Remove logging of full db url when the connection fails.#4220MyPhonesAlex wants to merge 1 commit into
MyPhonesAlex wants to merge 1 commit into
Conversation
The full connection string contains the password and logging passwords is a security risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent logging of full connection string when a database connection fails to be established.
Logging the full connection string results in the password getting logged, which is a security concern.
Details
This Affects the sqlops module.
When a SQL database connection fails, the whole database URL is logged, which includes the password. This is a security issue.
Whilst it is important to log that the connection has failed, secrets should not be included/
Solution
This PR alters the log point to log out the index of the connection, as opposed to the full URL.
Compatibility
This should have no compatibility issues.
Closing issues
N/A