Skip to content

Gracefully provide an error if JSON tailoring doesn't exist #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mab879 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

Gracefully provide an error if JSON tailoring doesn't exist #2372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions utils/autotailor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,9 @@ class Tailoring:
f.write(pretty_xml)

def import_json_tailoring(self, json_tailoring):
json_tailoring_path = pathlib.Path(json_tailoring).absolute()
if not json_tailoring_path.is_file():
raise ValueError("JSON Tailoring file does not exist or is not a file.")

@jan-cerny jan-cerny Jun 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the file name to the error message.

with open(json_tailoring, "r") as jf:
tailoring_dict = json.load(jf)

Expand Down
Loading