Skip to content

Adding support of full screen / popout map - #696

Merged
AgreeDK merged 4 commits into
OpenSAK-Org:betafrom
blazerat:database/add-move
Aug 9, 2026
Merged

Adding support of full screen / popout map#696
AgreeDK merged 4 commits into
OpenSAK-Org:betafrom
blazerat:database/add-move

Conversation

@blazerat

@blazerat blazerat commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Adding support for full screen map, and popout map to another window / monitor.

@blazerat

blazerat commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

#598

@AgreeDK

AgreeDK commented Aug 9, 2026

Copy link
Copy Markdown
Member

@blazerat

Tested this locally against current beta (via git fetch origin pull/696/head:pr-696). Popout works — map detaches into its own floating window cleanly. But docking it back has a layout bug.

Repro:

Pop out the map (toolbar icon or Ctrl+Shift+M)
Close the pop-out window (or dock it back)
The bottom-right area now shows the map and the "Map disabled" placeholder side by side, instead of just the map

Root cause: the map lives inside a QStackedWidget (self._map_stack, added in #638) that swaps between the live map (index 0) and the disabled-placeholder QLabel (index 1). _dock_map_back() reparents self._map_widget straight into self._bottom_splitter:

python
self._bottom_splitter.insertWidget(1, self._map_widget)

instead of back into self._map_stack. This leaves _map_stack (still showing whichever page was last active — often the placeholder) sitting in the splitter, with the map widget inserted alongside it as a second, separate item. Hence the split view.

Suggested fix in _dock_map_back():

python
self._map_stack.insertWidget(0, self._map_widget)
self._update_map_visibility()

instead of the current self._bottom_splitter.insertWidget(1, self._map_widget). _popout_map() should be fine as-is since it pulls the widget out of the stack via take_widget() regardless of which container currently holds it.

Happy to retest once this is in — the popout/maximize behavior itself looks solid otherwise.

@AgreeDK

AgreeDK commented Aug 9, 2026

Copy link
Copy Markdown
Member

@blazerat
Retested with the latest commit (8bec3e4) — the dock-back layout issue is fixed. Popped out, closed the window, docked back — map area renders correctly now, no more split view. Unit tests (test_map_maximize_popout.py, test_map_widget.py, 102 tests) and mypy are clean too.

One more thing before merging: this PR is currently targeting main instead of beta. We use beta as the active development branch and only merge into main for stable releases, so could you retarget the base branch to beta? You can do that from the dropdown next to the branch names near the top of the PR — no need to recreate the PR.

Nice work on this one — the maximize/popout combo is a great addition.

@blazerat
blazerat changed the base branch from main to beta August 9, 2026 15:51
@blazerat

blazerat commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Changed target.

@AgreeDK
AgreeDK merged commit 955c02a into OpenSAK-Org:beta Aug 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants