Adding support of full screen / popout map - #696
Conversation
|
Tested this locally against current beta (via git fetch origin pull/696/head:pr-696). Popout works — map detaches into its own floating window cleanly. But docking it back has a layout bug. Repro: Pop out the map (toolbar icon or Ctrl+Shift+M) Root cause: the map lives inside a QStackedWidget (self._map_stack, added in #638) that swaps between the live map (index 0) and the disabled-placeholder QLabel (index 1). _dock_map_back() reparents self._map_widget straight into self._bottom_splitter: python instead of back into self._map_stack. This leaves _map_stack (still showing whichever page was last active — often the placeholder) sitting in the splitter, with the map widget inserted alongside it as a second, separate item. Hence the split view. Suggested fix in _dock_map_back(): python instead of the current self._bottom_splitter.insertWidget(1, self._map_widget). _popout_map() should be fine as-is since it pulls the widget out of the stack via take_widget() regardless of which container currently holds it. Happy to retest once this is in — the popout/maximize behavior itself looks solid otherwise. |
|
@blazerat One more thing before merging: this PR is currently targeting main instead of beta. We use beta as the active development branch and only merge into main for stable releases, so could you retarget the base branch to beta? You can do that from the dropdown next to the branch names near the top of the PR — no need to recreate the PR. Nice work on this one — the maximize/popout combo is a great addition. |
|
Changed target. |
Adding support for full screen map, and popout map to another window / monitor.