Skip to content

Nhse o40 orkv.i141 silvermachine#3

Draft
martinsumner wants to merge 52 commits intoopenriak-4.0from
nhse-o40-orkv.i141-silvermachine
Draft

Nhse o40 orkv.i141 silvermachine#3
martinsumner wants to merge 52 commits intoopenriak-4.0from
nhse-o40-orkv.i141-silvermachine

Conversation

@martinsumner
Copy link
Copy Markdown
Contributor

@martinsumner martinsumner commented Apr 24, 2026

Switch HTTP API to use SilverMachine not WebMachine/Mochiweb.

Intentions are:

  • improve performance of common requests, especially with significant volumes of index entries and/or user object metadata;
  • simplify the callbacks required within the application;
  • only implement the basics of HTTP, the full extent of rules (i.e. equivalent webmachine decision_core) may be implemented in the callbacks, but aren't applied by default;
  • allow for streaming on both inbound request bodies as well as outbound response bodies, to ready support for file upload/downloads;
  • simplify the task of providing SSL handshake information to the application

@martinsumner
Initial Commit
af08451 
WIP.  A framework of modules and functions for SliverMachine.
@martinsumner
Initial test of get_body
fd5c2b4
@martinsumner
Fix formatting of new files
256151c 
Apply only to new files, or heavily altered files so that broader change history is maintained.
@martinsumner
Add basic chunking support (receive body)
ea3034b
@martinsumner
Add further tests - plus date caching
b815a5c
@martinsumner
Add behaviour
3c11b94 
Also add callback module and unit test the sending of responses both streamed and whole.
@martinsumner
Formatting
b471a74
@martinsumner
Accepting chunked requests in slices
57d1867 
Plus some further testing/formatting
@martinsumner
Formatting
df18274
@martinsumner
Add initial end-to-end test
f9469ae
@martinsumner
Revert clock bakc to ETS, and add negative tests
2812d4b
@martinsumner
Add monitoring of exits on acceptors
81d1b4e
@martinsumner
Pass the split path as well as path
f4a27d3
@martinsumner
Extend tests, add KV store test
be07044
@martinsumner
Add file upload/download test
7ccac06
@martinsumner
Formatting
52afe86
@martinsumner
Chunked puts
ab1a5b2
@martinsumner
Check keepalive in HTTP 1.0
65a4040
@martinsumner
Remove webmachine/mochiweb
9333085 
Retain mohijson2 and mochinum to ease transition
@martinsumner
Remove mochijson2/mochinum - included in rhc
a011b1d
@martinsumner
Remove leading empty bin if it occurs
3a1714f 
Where URI starts "/" will add a leading <<>> to the split path - which is confusing and easy to forget about.
@martinsumner
Use nomatch, and context to be last not first
01ddd3f 
Address initial feedback
@martinsumner
Optimise clock management
81beed1 
Also provides functions for converting Last Modified Date in KV GET.
@martinsumner
Tidy-up initial configuration
c553fe2
@martinsumner
Fix return tuple from security function
697631e
@martinsumner
Update riak_api_web_security.erl
ee81ccc
@martinsumner
Be explicit peer is IP
adf5b51
@martinsumner
Missed peer()
fa6a194
@martinsumner
Correct security type for peer
94ec8f7
@martinsumner
Align params type with uri_string:dissect_query
9d66650
@martinsumner
Unit test request line error handling
746f98f
@martinsumner
Trim both ends of path
95b5314
@martinsumner
Use binary split not string split
b826e48
@martinsumner
RFC requires only leading whitespace to be removed from header
c9139dd 
Also compile the binary pattern, and cache in a persistent term to speed up parsing
@martinsumner
RFC requires trimming both leading and trailing whitespace
1793961 
https://greenbytes.de/tech/webdav/rfc7230.html#header.fields
@martinsumner
compile URL separator
261afdc
@martinsumner
Revert "compile URL separator"
b45d244 
This reverts commit 261afdc.
@martinsumner
Only compile separators if not single character
5d7bb83
@martinsumner
Extend testing of errors
2af1af0
@martinsumner
Allow for neither content-length or transfer-encoding
d564509 
Just assume that it is empty
@martinsumner
Hack improvement to uri parse
07d49b5 
The uri_string:normalize is going to decode that path and the query params (resolve any percent encoding, then check the outcome is unicode).  It will also handle any dot segments.

If there are no dots, or percent encoding - this is unnecessary - the parsed outcome will be the same.  This will normally be the case - so bypass normalization if possible.

Paths can be quite long (with long bucket names, keys etc) - so avoiding this step has value.
@martinsumner
Tidy-up changes to parse vs normalise
6bc535c
@martinsumner
Don't leave URI elements quoted
aa0441e
@martinsumner
Handle no auth-headers
24c3964
@martinsumner martinsumner mentioned this pull request Apr 24, 2026
Draft
@martinsumner
Set recv buffer
c9dbccf 
Defaults to 1460 on OTP26 - and this means that not all data available in buffer
@martinsumner
fmt issue
7e0e92c
@martinsumner
Remove cached vs uncached clock test
211af58 
Nature of clock implementation changed - and so all tests may use cached clock - and so no longer a valid comparison.
@martinsumner
Get Peer and Cert at start of connection
6ec0469 
Reuse Peer/Cert in all check_permissions callback on the connection.
@martinsumner
Format fix
917f6cd
@martinsumner
Make type definition more consistent
ffa7553
@martinsumner
And export type
a417d2e
@martinsumner
Increase default backlog
99b9bab 
128 aligns with mochiweb - otherwise some tests with riak_test that use large bursts of connections may fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@martinsumner