Skip to content

bound destination writes in win32_utf8cpy #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aizu-m wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bound destination writes in win32_utf8cpy #1659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cups/dnssd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2606,10 +2606,11 @@ win32_utf8cpy(char *dst, // I - Destination string
size_t dstsize) // I - Size of destination string
{
int ch; // Current character
char *dstend = dst + dstsize - 5; // End of destination string


// Loop until we run out of characters or buffer space...
while (*src && dstsize > 4)
while (*src && dst <= dstend)
{
// Get the current character...
ch = *src++;
Expand Down
Loading