Refactor trainer rank package API#777
Merged
Merged
Conversation
bradhilton
marked this pull request as ready for review
July 25, 2026 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
art.trainer_rank.__init__a readable public API facade and move implementation details into_impl.pyAdapterSelection,Unset, and typed optimizer state/layout schemasAnyusage with concrete adapter, autograd, distributed, and forward-path typesWhy
art.trainer_rankhad its complete implementation and public API interleaved in a single large__init__.py. Separating the implementation makes the supported surface easier to understand and review while retaining canonical public module paths.Validation
uv run ruff format --check .uv run ruff check .uv run ty check src/art/trainer_rank tests/unit/test_trainer_rank_validation.py tests/unit/test_trainer_rank_weird_shapes.py