Rework Megatron to Support Adding New Models#674
Open
Conversation
…_and_trainability_main # Conflicts: # src/art/megatron/train.py
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
# Conflicts: # pyproject.toml # src/art/local/backend.py # src/art/megatron/compile_workarounds.py # src/art/megatron/flex_attention.py # src/art/megatron/jobs.py # src/art/megatron/lora.py # src/art/megatron/offload.py # src/art/megatron/provider.py # src/art/megatron/runtime/backend.py # src/art/megatron/service.py # src/art/megatron/setup.sh # src/art/megatron/train.py # src/art/pipeline_trainer/trainer.py # src/art/preprocessing/tokenize.py # src/art/tinker/renderers.py # src/art/tinker/server.py # src/art/unsloth/service.py # src/art/unsloth/train.py # src/art/vllm/patches.py # tests/integration/megatron/model_support/oracle_worker.py # tests/unit/test_preprocessing_tokenize.py # tests/unit/test_vllm_patches_contract.py # uv.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New/General Model Support
This PR turns the Megatron/vLLM/Qwen model-support work into a production path rather than a pile of model-specific patches.
Motivation / Outcome
vllmin the main environment. vLLM now lives in a separateart-vllm-runtimepackage/venv with its own lockfile, so ART can pin its own Torch/Flash/TE stack independently.art-vllm-runtimewheel plus itspyproject.toml,uv.lock, and manifest into the rootopenpipe-artwheel/sdist without addingvllmto root package metadata. Release/package workflows use the new build script and validate that published ART artifacts contain the runtime bundle while keeping vLLM install-time resolution isolated to the managed runtime environment. Packaging/release has been tested locally to the extent we can, but needs to be validated in the real GitHub release process and actual installation.tests/integration/megatron/....Validation
Future Validation