Move ISSUE-033 and ISSUE-034 to completed.md, and finish ISSUE-034 in docs/codebase - #22
Merged
Sellafield merged 2 commits intoAug 13, 2026
Merged
Conversation
Both fixes are merged - PR OpenPerpetuum#19 for ISSUE-033 and PR OpenPerpetuum#20 for ISSUE-034 - so the entries are set to DONE and moved, per the Backlog Rules in CLAUDE.md. Each entry now records what actually shipped: the Proposed Fix section is replaced by a Fix section describing the change, a Files Changed section, and a note naming the merged PR. For ISSUE-034 the Fix also states which of the two options was taken for the two .claude/knowledge/architecture.md references - they were repointed at docs/codebase/ARCHITECTURE.md rather than creating the missing file. Also restores the --- separator between entries in issues.md. The three entries added in PR OpenPerpetuum#18 were missing it, and removing two of them left ISSUE-035 and ISSUE-032 adjacent with no rule between them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
meketreve
force-pushed
the
backlog-033-034-done
branch
from
August 13, 2026 11:13
37a0034 to
70b2feb
Compare
Contributor
Author
|
Rebased onto develop now that #21 is merged. No conflict: your ISSUE-036/037/038 entries and the |
PR OpenPerpetuum#20 fixed the run command in CLAUDE.md, but ISSUE-034 had only surveyed that file. The same mistake sits in three files under docs/codebase/, which is the authoritative documentation set: - TESTING.md gives the manual-testing command as dotnet run -- --GameRoot "<path>" - STACK.md describes McMaster.Extensions.CommandLineUtils as parsing a --GameRoot option - STRUCTURE.md describes Program.cs as parsing --GameRoot src/Perpetuum.Server/Program.cs declares the game root positionally, via app.Argument("<GAMEROOT>", ...), so the option does not exist and the documented command fails with Unrecognized option '--GameRoot'. TESTING.md matters most of the three: the repository has no automated test suite, so running the server by hand is the only validation path a contributor has, and the command given for it could not work. Widen the ISSUE-034 entry in completed.md to cover these three files rather than closing it as done while the same defect remains in the docs it points contributors at. --GameRoot remains valid for Perpetuum.ServerService2, which reads GameRoot from appsettings.json, and is untouched. Five further occurrences under docs/superpowers/plans/ are dated records of plans already carried out and are left as written. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up bookkeeping for the two fixes you merged this morning: #19 (ISSUE-033) and #20 (ISSUE-034). The Backlog Rules in
CLAUDE.mdsay to update related backlog items after implementation and to move completed items tocompleted.md, which is what this does — plus the part of ISSUE-034 that the original entry had missed.What changed
docs/backlog/issues.md— ISSUE-033 and ISSUE-034 entries removed; ISSUE-035 stays, stillTODO.# Last ID usedis untouched.docs/backlog/completed.md— both entries appended withStatus: DONE, their### Proposed Fixreplaced by a### Fixdescribing what actually shipped, plus### Files Changedand a note naming the merged PR.docs/codebase/TESTING.md,STACK.md,STRUCTURE.md— the--GameRootcorrection from Fix the run command and ten broken paths in CLAUDE.md #20, applied where it was still missing.The ISSUE-034 entry records which of the two options was taken for the two
.claude/knowledge/architecture.mdreferences: repointed atdocs/codebase/ARCHITECTURE.mdrather than creating the missing file. If you would rather have the file, say so and both the code change and this entry are two lines to flip.One unrelated tidy: the three entries added in #18 were missing the
---separator that every other entry inissues.mdcarries. Removing two of them left ISSUE-035 and ISSUE-032 adjacent with no rule between them, so the separator is restored there.Finishing ISSUE-034
ISSUE-034 surveyed
CLAUDE.mdonly, so #20 fixed the run command there and nowhere else. The same mistake is still in three files underdocs/codebase/:TESTING.md:34dotnet run -- --GameRoot "E:\PerpetuumServer2\data"STACK.md:53McMaster.Extensions.CommandLineUtilsdescribed as parsing a--GameRootoptionSTRUCTURE.md:194Program.csdescribed as parsing--GameRootsrc/Perpetuum.Server/Program.csdeclares the game root positionally —app.Argument("<GAMEROOT>", ...)on line 15 — so the option does not exist and the documented command fails withUnrecognized option '--GameRoot'.TESTING.mdis the one that matters most. The repository has no automated test suite, so running the server by hand is the only validation path a contributor has, and the command given for it could not work. Closing ISSUE-034 as done while that line stood seemed worse than widening the entry, so thecompleted.mdentry now covers all four files and its title reflects the wider scope.--GameRootremains valid forPerpetuum.ServerService2, which readsGameRootfromappsettings.json, and is untouched. Five further occurrences underdocs/superpowers/plans/are dated records of plans already carried out, so they are left as written rather than rewritten after the fact — say the word if you would rather they were updated too.Note on convention
ISSUE-031 and ISSUE-032 are
DONEbut still sit inissues.md, so "move when complete" does not look like a hard rule in practice. I moved these two becausecompleted.mdis where the rule points; if you would rather keep recent DONE entries in place, drop thecompleted.mdhalf of this PR and I will just flip the status instead.Documentation only — no code, no build impact. Does not touch anything in #21.
🤖 Generated with Claude Code