fix: Prevent Chrome Translate from corrupting Tibetan unit titles - #16
Merged
choeying-10 merged 1 commit intoAug 11, 2026
Merged
Conversation
choeying-10
changed the title
Co-authored-by: Cursor <cursoragent@cursor.com>
choeying-10
force-pushed
the
fix/tibetan-unit-title-chrome-translate
branch
from
August 11, 2026 06:10
f859b7b to
40482d0
Compare
yogeshbhagatcode
requested changes
Aug 11, 2026
yogeshbhagatcode
left a comment
yogeshbhagatcode
left a comment
Collaborator
There was a problem hiding this comment.
Some test got failed:
Can you please check and see if there is anything concerning?
Comment on lines
-29
to
+37
| <h3 className="h3 mb-0">{unit.title}</h3> | ||
| <h3 | ||
| className={hasTibetan ? 'h3 mb-0 notranslate' : 'h3 mb-0'} | ||
| {...(hasTibetan ? { lang: 'bo', translate: 'no' } : {})} | ||
| > | ||
| {unit.title} | ||
| </h3> |
Collaborator
There was a problem hiding this comment.
Please test with different possible scenarios to make sure this fix can work in all the cases.
And it would be nice if you could list the scenarios that you test.
Author
those are test files of older PRs. not related to this current PR.
|
yogeshbhagatcode
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zh_HK) is unrelated.U+0F00–U+0FFF) inunit.titleand, only then, mark the unit<h3>withnotranslate,translate="no", andlang="bo"so Chrome skips translating that heading.