Skip to content

[com1]: make deposition erodable (initially)#1292

Merged
fso42 merged 1 commit into
masterfrom
PS_addErodibleLayer
Jun 26, 2026
Merged

[com1]: make deposition erodable (initially)#1292
fso42 merged 1 commit into
masterfrom
PS_addErodibleLayer

Conversation

@PaulaSp3

@PaulaSp3 PaulaSp3 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@PaulaSp3 PaulaSp3 requested review from awirb and fso42 June 10, 2026 11:35
@PaulaSp3 PaulaSp3 self-assigned this Jun 10, 2026
@PaulaSp3 PaulaSp3 added enhancement New feature or request DebrisFrame labels Jun 10, 2026
@PaulaSp3 PaulaSp3 requested a review from JuLa96 June 10, 2026 11:39
@qltysh

qltysh Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 0.04%.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA86.8%

Modified Files with Diff Coverage (5)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
avaframe/com1DFA/com1DFA.py88.9%1332, 3527-3529
Coverage rating: B Coverage rating: B
avaframe/in2Trans/transformFields.py77.8%92-95
Coverage rating: A Coverage rating: A
avaframe/out3Plot/plotUtils.py100.0%
Coverage rating: B Coverage rating: B
avaframe/com1DFA/deriveParameterSet.py50.0%906
Coverage rating: A Coverage rating: A
avaframe/in3Utils/geoTrans.py100.0%
Total92.5%
🤖 Increase coverage with AI coding...
In the `PS_addErodibleLayer` branch, add test coverage for this new code:

- `avaframe/com1DFA/com1DFA.py` -- Lines 1332 and 3527-3529
- `avaframe/com1DFA/deriveParameterSet.py` -- Line 906
- `avaframe/in2Trans/transformFields.py` -- Line 92-95

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFACfg.ini
Comment thread avaframe/com1DFA/com1DFACfg.ini Outdated
Comment thread avaframe/com1DFA/com1DFA.py
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py
Comment thread avaframe/com1DFA/com1DFA.py
@PaulaSp3 PaulaSp3 removed the request for review from JuLa96 June 18, 2026 08:47
@qltysh

qltysh Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

All good ✅

Comment thread avaframe/com1DFA/com1DFA.py
@PaulaSp3 PaulaSp3 force-pushed the PS_addErodibleLayer branch 3 times, most recently from 346d985 to 4360bef Compare June 23, 2026 10:13
@PaulaSp3 PaulaSp3 assigned fso42 and unassigned PaulaSp3 Jun 23, 2026
@fso42 fso42 assigned PaulaSp3 and unassigned fso42 Jun 25, 2026
@fso42

fso42 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Standardtest show difference! Please investigate

Comment thread avaframe/com1DFA/com1DFA.py Outdated
chore(github-actions): update Pixi setup action to v0.9.6

fix bug for ent when time dep rel is on

add flag for erdoable deposition; fix bug timedeprel

add test

add output entrainabe depth

add condition that adaptsfcstopped is switched on

no change in DEM header when computing between thickness and depth

Update avaframe/com1DFA/com1DFA.py
@fso42 fso42 force-pushed the PS_addErodibleLayer branch from 9300421 to 4ecd18d Compare June 26, 2026 16:00
@fso42

fso42 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Now Standardtests are ident, apart from known com5

@fso42 fso42 merged commit 76cb241 into master Jun 26, 2026
4 checks passed
@fso42 fso42 deleted the PS_addErodibleLayer branch June 26, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DebrisFrame enhancement New feature or request

Projects

None yet

3 participants