[com1]: make deposition erodable (initially)#1292
Merged
Merged
Conversation
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Components (1)
Modified Files with Diff Coverage (5)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
awirb
reviewed
Jun 12, 2026
fso42
requested changes
Jun 15, 2026
fso42
approved these changes
Jun 16, 2026
Contributor
346d985 to
4360bef
Compare
Contributor
|
Standardtest show difference! Please investigate |
3f50673 to
525be33
Compare
PaulaSp3
commented
Jun 26, 2026
chore(github-actions): update Pixi setup action to v0.9.6 fix bug for ent when time dep rel is on add flag for erdoable deposition; fix bug timedeprel add test add output entrainabe depth add condition that adaptsfcstopped is switched on no change in DEM header when computing between thickness and depth Update avaframe/com1DFA/com1DFA.py
9300421 to
4ecd18d
Compare
Contributor
|
Now Standardtests are ident, apart from known com5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

add an option that deposition is entrainable: (if
ent in simTypeList, adaptSfcStopped = 1, adaptSfcEntrainment = 1, entrainableDeposition = True)erodible layer:$h_{entrainable}$ ist die Höhe, nicht Mächtigkeit!!!)
(
before simulation:
$dem_{notEntrainable} = dem_{orig} - h_{entrainable}(t=0)$
for every timestep t and for every grid cell:
($\rho$ : density of flowing material, $thickness$ is derived from $h$ and slope)
closes Do we need on top of the topography an erodible layer? DebrisFrame#68
closes make deposited material erodible DebrisFrame#69
there are still a many open questions:
[com1]: improve adaptable topography DebrisFrame#66
fixes bugs, when using timedependent release and entrainment:
closes Test all variations (ent, res, sec release) with time dependent release DebrisFrame#74