Remove the sqlite3 file handling from the pipeline - #306
Merged
Conversation
The results of a job went into a per-machine sqlite3 file that had to be downloaded before the run and published back afterwards, and since #296 they go into the shared database instead. Which of the two was a tick box on the job, defaulting to the shared one. Nobody should be able to send a day of testing to a file nobody reads by unticking a box, and keeping the old path around only leaves two ways of doing the same thing for someone to wonder about later. Both are gone: - the "postgres" parameter, and the branches it guarded; - copying ~/TEST_LIBS_BACKUP/<machine>-sqlite3.db into the workspace before a run, copying it back after, and the sshPublisher that uploaded it; - fetching a machine's sqlite3.db in the two report stages, which now read the shared database directly; - keeping a week of dated backups of those files on every node; - dbPrefix and sshConfig, which existed only to name and publish that file, from runRegressiontest and its twenty-three callers. The scripts themselves are untouched and still write a sqlite3 file by default: that is what a developer running test.py gets, and what the GitHub checks use. It is the pipeline that no longer has a second way of doing this. --- Generated by Claude Code.
adrpo
enabled auto-merge (squash)
August 11, 2026 20:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #296 the results of a job go into the shared database. The old path — a per-machine
sqlite3.dbdownloaded before the run and published back afterwards — was still there, chosen by a tick box on the job:Nobody should be able to send a day of testing to a file nobody reads by unticking a box before a build, and keeping the old path around only leaves two ways of doing the same thing for someone to wonder about later. So it all goes:
postgresparameter and the branches it guarded;~/TEST_LIBS_BACKUP/<machine>-sqlite3.dbinto the workspace before a run, copying it back after, and thesshPublisherthat uploaded it;sqlite3.dbin the two report stages, which read the shared database directly;dbPrefixandsshConfig, which existed only to name and publish that file, fromrunRegressiontestand its 23 callers.The scripts are untouched.
test.pyand the report scripts still default to a localsqlite3.db, which is what a developer gets when running them by hand and what the GitHub checks use. It is the pipeline that no longer has a second way of doing this.Checked
Removing two positional parameters from a function with 23 callers is the kind of edit that goes wrong quietly, so the calls were rewritten by parsing each argument list rather than by matching text, and then verified against the new signature:
The check confirms every call is within the arity the signature allows and that the argument now in the
omcompilerposition is a boolean in all of them. That last one caught a genuine mistake while writing this: the first attempt also rewrote the definition, silently droppingomcompilerandextrasimflagsfrom the signature while every caller still passed them.Generated by Claude Code.