Skip to content

Remove the sqlite3 file handling from the pipeline - #306

Merged
adrpo merged 1 commit into
masterfrom
always-postgres
Aug 11, 2026
Merged

Remove the sqlite3 file handling from the pipeline#306
adrpo merged 1 commit into
masterfrom
always-postgres

Conversation

@adrpo

@adrpo adrpo commented Aug 11, 2026

Copy link
Copy Markdown
Member

Since #296 the results of a job go into the shared database. The old path — a per-machine sqlite3.db downloaded before the run and published back afterwards — was still there, chosen by a tick box on the job:

booleanParam(name: 'postgres', defaultValue: true, description: '... Untick to go back to the sqlite3 files.')

Nobody should be able to send a day of testing to a file nobody reads by unticking a box before a build, and keeping the old path around only leaves two ways of doing the same thing for someone to wonder about later. So it all goes:

  • the postgres parameter and the branches it guarded;
  • copying ~/TEST_LIBS_BACKUP/<machine>-sqlite3.db into the workspace before a run, copying it back after, and the sshPublisher that uploaded it;
  • fetching a machine's sqlite3.db in the two report stages, which read the shared database directly;
  • keeping a week of dated backups of those files on every node;
  • dbPrefix and sshConfig, which existed only to name and publish that file, from runRegressiontest and its 23 callers.

The scripts are untouched. test.py and the report scripts still default to a local sqlite3.db, which is what a developer gets when running them by hand and what the GitHub checks use. It is the pipeline that no longer has a second way of doing this.

Checked

Removing two positional parameters from a function with 23 callers is the kind of edit that goes wrong quietly, so the calls were rewritten by parsing each argument list rather than by matching text, and then verified against the new signature:

signature (14): branch, name, extraFlags, omsHash, omcompiler, extrasimflags, testFlags,
                removePackageOrder, conversionScript, jobs, libs_config_file, cmakeFlags,
                dockerfile, fmiSimulators
required: 9, optional: 5
23 calls checked, 0 problems

The check confirms every call is within the arity the signature allows and that the argument now in the omcompiler position is a boolean in all of them. That last one caught a genuine mistake while writing this: the first attempt also rewrote the definition, silently dropping omcompiler and extrasimflags from the signature while every caller still passed them.


Generated by Claude Code.

The results of a job went into a per-machine sqlite3 file that had to be
downloaded before the run and published back afterwards, and since #296 they go
into the shared database instead. Which of the two was a tick box on the job,
defaulting to the shared one.

Nobody should be able to send a day of testing to a file nobody reads by
unticking a box, and keeping the old path around only leaves two ways of doing
the same thing for someone to wonder about later. Both are gone:

  - the "postgres" parameter, and the branches it guarded;
  - copying ~/TEST_LIBS_BACKUP/<machine>-sqlite3.db into the workspace before a
    run, copying it back after, and the sshPublisher that uploaded it;
  - fetching a machine's sqlite3.db in the two report stages, which now read the
    shared database directly;
  - keeping a week of dated backups of those files on every node;
  - dbPrefix and sshConfig, which existed only to name and publish that file,
    from runRegressiontest and its twenty-three callers.

The scripts themselves are untouched and still write a sqlite3 file by default:
that is what a developer running test.py gets, and what the GitHub checks use.
It is the pipeline that no longer has a second way of doing this.

---
Generated by Claude Code.
@adrpo adrpo changed the title Take the choice of results database out of the job Remove the sqlite3 file handling from the pipeline Aug 11, 2026
@adrpo
adrpo enabled auto-merge (squash) August 11, 2026 20:16
@adrpo
adrpo merged commit 7fc4514 into master Aug 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant