Skip to content

Update the headers in ColPack#216

Closed
dreivmeister wants to merge 2 commits into
OpenModelica:masterfrom
dreivmeister:ColPack-headers
Closed

Update the headers in ColPack#216
dreivmeister wants to merge 2 commits into
OpenModelica:masterfrom
dreivmeister:ColPack-headers

Conversation

@dreivmeister

Copy link
Copy Markdown
Contributor

Update the header file paths in ColPackHeaders.h inside the ColPack package to fix make build errors. @linuslangenkamp

@linuslangenkamp

Copy link
Copy Markdown
Contributor

So the build error was only in the legacy make build or also in CMake? I was just wondering.

@dreivmeister

Copy link
Copy Markdown
Contributor Author

Yes exactly only the make build

@linuslangenkamp

Copy link
Copy Markdown
Contributor

Ahhh. I do not like to change the library because if we want to update the library at some point we have to remember which changes we did, e.g. here to change the include header. I guess we have to set the include directories correctly in the Makefile build. Then it is a more clean solution.

This was my bad when I merged the first version of Colpack in 3rdParty.

Will fix it tomorrow for Makefile.

@phannebohm

Copy link
Copy Markdown
Contributor

Ahhh. I do not like to change the library because if we want to update the library at some point we have to remember which changes we did, e.g. here to change the include header. I guess we have to set the include directories correctly in the Makefile build. Then it is a more clean solution.

Yes changing the library is probably not the way to go.

Will fix it tomorrow for Makefile.

I think @dreivmeister and myself found a solution already in OMCompiler/SimulationRuntime/c/Makefile.common. We only added ColPack/inc but we also need ColPack/src right?

@linuslangenkamp

linuslangenkamp commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Yes probably. Colpack includes those headers locally with #include "whatever.h" in its include header ColPack/inc/ColPackHeaders.h. So we should just add the Colpack/src directory and it should find those.

@phannebohm

Copy link
Copy Markdown
Contributor

Okay we fix this in OMCompiler and not here.

@phannebohm phannebohm closed this Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants