Update the headers in ColPack#216
Conversation
|
So the build error was only in the legacy make build or also in CMake? I was just wondering. |
|
Yes exactly only the make build |
|
Ahhh. I do not like to change the library because if we want to update the library at some point we have to remember which changes we did, e.g. here to change the include header. I guess we have to set the include directories correctly in the Makefile build. Then it is a more clean solution. This was my bad when I merged the first version of Colpack in 3rdParty. Will fix it tomorrow for Makefile. |
Yes changing the library is probably not the way to go.
I think @dreivmeister and myself found a solution already in |
|
Yes probably. Colpack includes those headers locally with |
|
Okay we fix this in OMCompiler and not here. |
Update the header file paths in ColPackHeaders.h inside the ColPack package to fix make build errors. @linuslangenkamp