Respect output policy validation result#9400
Open
jahnavik186 wants to merge 1 commit intoOpenMined:devfrom
Open
Respect output policy validation result#9400jahnavik186 wants to merge 1 commit intoOpenMined:devfrom
jahnavik186 wants to merge 1 commit intoOpenMined:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9326.
This PR prevents an Admin user from demoting their own role permissions.
Previously, an Admin could update their own user role and accidentally remove their own administrative privileges, potentially locking themselves out of admin access.
This change adds validation in
user_service.pyinside the user update flow to detect when:context.credentialsADMINWhen this happens, the update is rejected with a
SyftError:Admins cannot demote their own role!Affected Dependencies
None.
This change only modifies internal user update validation logic in:
packages/syft/src/syft/service/user/user_service.pyHow has this been tested?
Manual logic verification.
I verified the update path in
user_service.pyto ensure the new validation only blocks self-demotion by Admin users and does not affect other user role updates.Checklist