fix(offline_download): handle unknown-size offline download tasks#2622
Open
kobe-koto wants to merge 2 commits into
Open
fix(offline_download): handle unknown-size offline download tasks#2622kobe-koto wants to merge 2 commits into
kobe-koto wants to merge 2 commits into
Conversation
Member
|
模板 |
kobe-koto
changed the title
Author
|
已按模板更新 pr body 和标题 |
xrgzs
added
Module: Task
PIKACHUIM
approved these changes
Jun 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens offline download/transfer task reporting when the remote file size is unknown (or reported as total_bytes = 0), preventing non-finite progress values from breaking task APIs, and backfilling final sizes/progress on completion for stream-direct-upload flows.
Changes:
- Prevent
NaN/Infprogress values from propagating into task API JSON responses. - Avoid division-by-zero progress calculations for Aria2/qBittorrent when total size is unknown; force
progress=100on completed states. - Improve unknown-size handling for SimpleHttp and stream-direct-upload transfers, including backfilling
total_bytesto the transfer task and its parent task.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| server/handles/task.go | Sanitizes non-finite progress values before serializing task info to JSON. |
| internal/offline_download/tool/transfer.go | Improves stream-direct-upload transfer behavior for unknown sizes; propagates final size/progress to parent. |
| internal/offline_download/tool/download.go | Wires parent download task into transfer task so final size/progress can be reflected upstream. |
| internal/offline_download/qbit/qbit.go | Guards progress calculation when size is zero/unknown; sets progress to 100% when completed. |
| internal/offline_download/http/client.go | Handles missing/invalid Content-Length for SimpleHttp, including setting final total bytes after download. |
| internal/offline_download/aria2/aria2.go | Guards progress calculation when total is zero/unknown; sets progress to 100% when completed/seeding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+83
to
+88
| if downloadSize < 0 { | ||
| if _, err := s.CacheFullAndWriter(nil, nil); err != nil { | ||
| return err | ||
| } | ||
| t.setKnownSize(s.GetSize()) | ||
| } |
Comment on lines
+83
to
+88
| if fileSize <= 0 { | ||
| start, end, err := http_range.ParseContentRange(resp.Header.Get("Content-Range")) | ||
| if err == nil && end >= start { | ||
| fileSize = end - start + 1 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
修复 Aria2/qBittorrent 在
total_bytes = 0时计算出非有限进度，导致任务接口 JSON 编码失败并返回空 body 的问题。修复 SimpleHttp 普通下载在响应缺少
Content-Length时，任务完成后不返回total_bytes、进度不显示100%的问题。修复
Download stream direct upload模式下远端大小未知时，上传完成后未把实际大小回填到 transfer task 和父 offline download task的问题。在任务 API 响应层兜底清理
Infprogress，避免单个异常任务影响整个任务列表接口。This PR has breaking changes.
/ 此 PR 包含破坏性变更。
This PR changes public API, config, storage format, or migration behavior.
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
This PR requires corresponding changes in related repositories.
/ 此 PR 需要关联仓库同步修改。
Testing / 测试
go test ./...在 Web 前端使用 Aria2 和 Simple HTTP （
Download stream direct upload和其他任意 policy） 作为后端下载一不返回 HEAD 或 HEAD 中不返回有效 Content-Length 的链接，在/@manage/tasks/offline_download中观察是否能渲染正在下载中的任务，以及下载完成后该任务是否返回有效 total bytes.Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。