Skip to content

Fix #120: start and stop each server plugin only once #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgaffigan merged 2 commits into from
Jul 31, 2026
Merged

Fix #120: start and stop each server plugin only once #397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8771d6d
Fix #120: start and stop each server plugin only once
ggiannola Jul 29, 2026
69962ae
Use a Set for serverPlugins instead of a de-duplicating adder
ggiannola Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions server/src/main/java/com/mirth/connect/server/controllers/DefaultExtensionController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,14 @@ public class DefaultExtensionController extends ExtensionController {

// these are plugins for specific extension points, keyed by plugin name
// (not path)
private List<ServerPlugin> serverPlugins = new ArrayList<ServerPlugin>();
/*
* A plugin class may implement several of the plugin type interfaces, in which case it is
* registered once for each interface it implements. A Set holds a single entry per plugin,
* so start() and stop() are invoked once per plugin rather than once per interface.
* LinkedHashSet because initPlugins loads plugins in a deliberate order (by plugin weight)
* and that order is preserved when they are started and stopped.
*/
private Set<ServerPlugin> serverPlugins = new LinkedHashSet<ServerPlugin>();
private Map<String, ServicePlugin> servicePlugins = new LinkedHashMap<String, ServicePlugin>();
private Map<String, ChannelPlugin> channelPlugins = new LinkedHashMap<String, ChannelPlugin>();
private Map<String, CodeTemplateServerPlugin> codeTemplateServerPlugins = new LinkedHashMap<String, CodeTemplateServerPlugin>();
Expand Down Expand Up @@ -716,7 +723,8 @@ public List<String> getClientLibraries() {
}

public List<ServerPlugin> getServerPlugins() {
return serverPlugins;
// Copied into a List so the ExtensionController signature stays unchanged for extensions.
return new ArrayList<ServerPlugin>(serverPlugins);
}

void extractZipEntry(ZipEntry entry, File installTempDir, ZipFile zipFile) throws IOException {
Expand Down
Loading